fix: replaced file existence check for shell check

[afonsojramos]

In theory, fixes #1435.

@ririxidev @theRealPadster

[theRealPadster]

$SHELL doesn't work in Fish. For that matter, the rest of the syntax isn't compatible with Fish anyways, so the script can not be run with Fish. (You'd need to run under a different shell, but it would be nice if spicetify was available in the Fish$PATH afterwards.) I believe that $SHELL is meant to output the currently running shell, which would mean that it only adds to the $PATH of a single shell, which we don't want.

[afonsojramos]

the rest of the syntax isn't compatible with Fish anyways

I thought #1426 made it work, what do you mean? Or are you simply referring to if [[ -f "$HOME/.config/fish/config.fish" ]]? I can roll that back.

which would mean that it only adds to the $PATH of a single shell, which we don't want.

I disagree here. This should be the default behaviour.

[theRealPadster]

That commit enables it to add to the fish path, but the script itself will not run under fish because fish isn't posix-compatible and the syntax isn't identical.

I don't see the harm in adding it to multiple shells if the user has multiple shells set up. I generally use fish, but have zsh on MacOS as well, and have experimented with some different ones. This is why I think it's still a net positive to include support for the fish path even though the script can't be run from fish

Context:

fish, the friendly interactive shell, is a commandline shell intended to be interactive and user-friendly.

fish is intentionally not fully POSIX compliant, it aims at addressing POSIX inconsistencies (as perceived by the creators) with a simplified or a different syntax. This means that even simple POSIX compliant scripts may require some significant adaptation or even full rewriting to run with fish.

https://wiki.archlinux.org/title/fish

[afonsojramos]

In that case I'll rollback the fish change. Either way, the installation must be run in a POSIX compliant shell, so it will then work with fish after installation.

[afonsojramos]

@theRealPadster now we should be good to cover all edge cases.

[theRealPadster]

@theRealPadster now we should be good to cover all edge cases.

Awesome, looks good to me, thanks!

[rxri]

Yeah looks good now ig. Now there should be no issues with zsh users etc.