feat: improve handling of new Spotify versions #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxri
requested changes
May 21, 2022
|
@ririxidev I get that, however, this is something for the CLI so... What do you suggest as an alternative? This PR also tackles the fact that currently the CLI breaks applying in the current version. |
|
In the end, I just want to avoid this: |
rxri
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're always getting reports of the Cannot find index of React app. This fixes that and improves how we communicate to users that we only support until a certain release of Spotify. This also means that we should update the
supportedSpotifyVersionevery time that we release a new version to support a new Spotify version.Additionally, with this "fix", users can use Spicetify with future versions of Spotify, even if it isn't fully supported yet.