Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webnowplaying): memory leak #2228

Merged
merged 3 commits into from Mar 30, 2023
Merged

fix(webnowplaying): memory leak #2228

merged 3 commits into from Mar 30, 2023

Conversation

keifufu
Copy link

@keifufu keifufu commented Mar 30, 2023

  • Fixed a memory leak that occurs when the extension fails to connect for ~256 times.
    Chromium has a global websocket connection limit of 256 and it just goes crazy when it hits that, this was caused because I wasn't closing the websocket properly before trying to reconnect.
  • Fixed WebNowPlaying being unable to heart/unheart a song
  • Fixed some issues with caching

@keifufu keifufu requested a review from a team as a code owner March 30, 2023 00:35
@kyrie25 kyrie25 changed the title fix: webnowplaying memory leak fix(webnowplaying): memory leak Mar 30, 2023
@rxri rxri merged commit f36deb3 into spicetify:master Mar 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxri rxri rxri approved these changes

@kyrie25 kyrie25 kyrie25 approved these changes

@theRealPadster theRealPadster Awaiting requested review from theRealPadster theRealPadster was automatically assigned from spicetify/cli

@CharlieS1103 CharlieS1103 Awaiting requested review from CharlieS1103 CharlieS1103 was automatically assigned from spicetify/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keifufu @rxri @kyrie25