Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lyrics-plus): playbar button #2327

Merged
merged 14 commits into from May 6, 2023
Merged

Conversation

ohitstom
Copy link
Contributor

@ohitstom ohitstom commented May 5, 2023

resolves #2314.

image
image

@ohitstom ohitstom requested a review from a team as a code owner May 5, 2023 19:53
@ohitstom ohitstom marked this pull request as draft May 5, 2023 23:21
@ohitstom ohitstom marked this pull request as ready for review May 6, 2023 13:18
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
@ohitstom ohitstom requested a review from kyrie25 May 6, 2023 14:21
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
ohitstom and others added 2 commits May 6, 2023 15:39
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
CustomApps/lyrics-plus/PlaybarButton.js Outdated Show resolved Hide resolved
ohitstom and others added 5 commits May 6, 2023 16:16
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
@ohitstom ohitstom requested a review from kyrie25 May 6, 2023 15:18
kyrie25
kyrie25 previously requested changes May 6, 2023
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one, wording is kinda weird

CustomApps/lyrics-plus/Settings.js Outdated Show resolved Hide resolved
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
@ohitstom ohitstom requested a review from kyrie25 May 6, 2023 16:41
@kyrie25 kyrie25 merged commit f577325 into spicetify:master May 6, 2023
6 checks passed
@ohitstom ohitstom deleted the lyrics-plus branch May 14, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to access Lyrics Plus from default lyrics button
3 participants