Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrapper/topbar): use History.listen event instead of the observer #2826

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

rxri
Copy link
Member

@rxri rxri commented Feb 13, 2024

fixes #2806
explanation: the topbar is only re-rendered in few specific page switches so

Also add css map for `main-noConnection` found in version `1.2.31.1205.g4d59ad7c`
@rxri rxri changed the title fix(TopBar): use History.listen event instead of the observer fix(wrapper/topbar): use History.listen event instead of the observer Feb 13, 2024
@rxri rxri mentioned this pull request Feb 14, 2024
2 tasks
Copy link
Member

@CharlieS1103 CharlieS1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shablamo! Looks like we got ourselves a certified prodigy.

@rxri
Copy link
Member Author

rxri commented Feb 14, 2024

bruh

@rxri rxri merged commit 6f28790 into master Feb 14, 2024
10 checks passed
@rxri rxri deleted the fix/topbarMount branch February 14, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants