Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(keyboardshortcut): repair functionality, re-implement removed binds & add new binds #2860

Merged
merged 17 commits into from
Mar 11, 2024

Conversation

ohitstom
Copy link
Contributor

@ohitstom ohitstom commented Feb 25, 2024

resolves #2857

Finished:

Future PR:

Looking for collaborative ideas on binds!

@rxri rxri marked this pull request as draft February 26, 2024 19:59
@ohitstom ohitstom changed the title refactor(keyboardshortcut): repair functionality & re-implement old binds refactor(keyboardshortcut): repair functionality, re-implement removed binds & add new binds Mar 4, 2024
@ohitstom ohitstom marked this pull request as ready for review March 7, 2024 11:28
@ohitstom
Copy link
Contributor Author

ohitstom commented Mar 7, 2024

wont find time atm for the last 3, so might as-well work with what we've got and hopefully get it merged before the next release

@afonsojramos afonsojramos merged commit 35e4312 into spicetify:master Mar 11, 2024
13 checks passed
rxri pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exts] Re-add vim bindings to keyboardShortcut.js
3 participants