Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preprocess): adapt regex to find react on 1.2.32 #2863

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Conversation

rxri
Copy link
Member

@rxri rxri commented Feb 26, 2024

  • new functionality for Replace & ReplaceOnce to not catch strings like $e as matching group
  • panel api has been removed with this commit
  • removing logging functions is fixed
  • few outdated stuff from apply/preprocess has been removed too

I also think it's safe to say that we can drop official support for <1.2.13, meaning we will only support one version without forced Library X

fixes #2861

This commit also adds new functionality to `Replace` & `ReplaceOnce` to not mess up strings like `$e` with submatches that function provides.
Panel API is removed with this commit
and removing logging functions is fixed
@rxri rxri changed the title fix: stop assigning references fix(preprocess): finding react element Feb 26, 2024
@rxri rxri changed the title fix(preprocess): finding react element fix(preprocess): finding react element on 1.2.32 Feb 26, 2024
@rxri rxri changed the title fix(preprocess): finding react element on 1.2.32 fix(preprocess): adapt regex to find react on 1.2.32 Feb 26, 2024
Copy link
Member

@CharlieS1103 CharlieS1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@rxri rxri merged commit c20c485 into master Feb 27, 2024
9 checks passed
@rxri rxri deleted the fix/preprocess branch February 27, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify v1.2.32 blanks on startup if custom apps used
3 participants