Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrapper/cards): re-add "Default" as FeatureCard #2990

Merged
merged 1 commit into from Apr 27, 2024

Conversation

rxri
Copy link
Member

@rxri rxri commented Apr 27, 2024

This matches the type of card better, Default is a barebone card (which is exposed via reactComponentsUI.Card), but the Default card we had before is more as of FeatureCard that's why I'm re-adding it as this one

Fixes Bergbok/Spicetify-Creations#6
Fixes harbassan/spicetify-apps#87
however this requires changing Default export to FeatureCard

This matches the type of card better, `Default` is a barebone card (which is exposed via `reactComponentsUI.Card`), but the `Default` card we had before is more as of `FeatureCard` that's why I'm re-adding it as this one
@graphite-app graphite-app bot added the wrapper Issue or Pull Request about wrapper functionality label Apr 27, 2024
Copy link

graphite-app bot commented Apr 27, 2024

Graphite Automations

"Add `wrapper` label on wrapper related changes" took an action on this PR • (04/27/24)

1 label was added to this PR based on ririxi's automation.

@afonsojramos afonsojramos merged commit 205a28b into master Apr 27, 2024
10 checks passed
@afonsojramos afonsojramos deleted the feat/wrapper branch April 27, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrapper Issue or Pull Request about wrapper functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlists not showing up in playlist tags page SpotifyCard not rendering
3 participants