Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of gold arguments for ChFinAnn #64

Closed
donovanOng opened this issue Jun 1, 2023 · 11 comments
Closed

Number of gold arguments for ChFinAnn #64

donovanOng opened this issue Jun 1, 2023 · 11 comments
Labels
discussion Discussion on DocEE and SentEE

Comments

@donovanOng
Copy link

donovanOng commented Jun 1, 2023

** Problems **

How many gold arguments are used to calculate the P/R/F1 for ChFinAnn reported in the paper?

@donovanOng donovanOng added the discussion Discussion on DocEE and SentEE label Jun 1, 2023
@Spico197
Copy link
Owner

Spico197 commented Jun 1, 2023

The number of gold arguments in PTPCG is the same as other baselines that use ChFinAnn.
You can download the original data from here and get the statistics.

@Spico197
Copy link
Owner

Spico197 commented Jun 5, 2023

Hi there, does my response answer your questions? I'd like to close this issue if there's no further discussion.

@donovanOng
Copy link
Author

Hi @Spico197 after training the model on ChFinAnn, the test data arguments TP+FN = 28,545 but when I count the arguments from the original test data, it is 29,345.

I traced the missing arguments and found that they are dropped during the truncation of sentences and documents. Can you confirm?

Thanks.

@Spico197
Copy link
Owner

Spico197 commented Jun 6, 2023

Yes. The default setting of the number of sentences in a document is 64, while the max sequence length is 128, so some documents are trucated. Doc2EDAG, GIT, PTPCG use the same setting. It may be potentially unfair if you use other settings.

@Spico197
Copy link
Owner

Spico197 commented Jun 6, 2023

I didn't check the exact numbers yet, but do you mean arguments instead of mentions or entities?

@donovanOng
Copy link
Author

yes, I mean the arguments in event tables

@Spico197
Copy link
Owner

Spico197 commented Jun 6, 2023

I understand. I'll try to get the statistics soon.

@donovanOng
Copy link
Author

@Spico197 Hi! Would you be able to share the model predictions for ChFinAnn and DuEE-fin dev? I really appreciate your valuable time.

@Spico197
Copy link
Owner

Hi there, sorry for the late response. Things been busy these days.

The attachment below contains:

  • PTPCG test evaluation results on ChFinAnn Epoch=57 (you can calculate the number of arguments from TP, FP and FNs in overall/overall) and middle prediction outputs.
  • PTPCG dev evaluation results and middle prediction outputs on DuEE-Fin Epoch=99

PTPCG-MiddleResults.zip

@Spico197
Copy link
Owner

In case of any inconvenience for your analysis, I updated the PTPCG task dump trained on DuEE-Fin.
You can find it here: https://github.com/Spico197/DocEE/releases/tag/tasks-ptpcg-dueefin

@donovanOng
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion on DocEE and SentEE
Projects
None yet
Development

No branches or pull requests

2 participants