Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spiffeid package #54

Closed
azdagron opened this issue Mar 9, 2020 · 0 comments · Fixed by #77
Closed

Implement spiffeid package #54

azdagron opened this issue Mar 9, 2020 · 0 comments · Fixed by #77
Assignees
Projects

Comments

@azdagron
Copy link
Member

azdagron commented Mar 9, 2020

The spiffeid package provides types for the SPIFFE ID and Trust Domain. Some of the functionality has been implemented as part of the V2 scaffolding. However, there are two remaining methods: Parse and ParseURI. These two methods are in charge of parsing a SPIFFE ID from a string or URI. They should perform proper validation of the URI, ensuring that it is well formed according to the SPIFFE ID specification.

In addition, the trust domain portion of the SPIFFE ID should be normalized to lower-case to facilitate SPIFFE ID comparison.

Unit-tests for all functionality in the spiffeid package should be introduced as part of implementing this issue.

@azdagron azdagron added this to To do in V2 API via automation Mar 9, 2020
@martincapello martincapello self-assigned this Mar 10, 2020
@martincapello martincapello moved this from To do to In progress in V2 API Mar 10, 2020
@martincapello martincapello moved this from In progress to Reviewer approved in V2 API Mar 23, 2020
@martincapello martincapello moved this from Reviewer approved to Done in V2 API Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
V2 API
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants