Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jwtsvid.SVID type and validation #67

Closed
azdagron opened this issue Mar 9, 2020 · 1 comment · Fixed by #84
Closed

Implement jwtsvid.SVID type and validation #67

azdagron opened this issue Mar 9, 2020 · 1 comment · Fixed by #84
Assignees
Projects

Comments

@azdagron
Copy link
Member

azdagron commented Mar 9, 2020

This issue is to implement the jwtsvid.SVID type as outlined in svid.go along with code to parse and validate a JWT-SVID according to the specification.

The SVID type should contain the raw JWT-SVID token as well as denormalized convenience fields for various claims, like the SPIFFE ID (i.e. sub), audience (i.e. aud) and a bucket for the other claims.

There should be two methods:

  1. ParseInsecure - simply parses a token into the SVID type but does not validate. This is mainly useful when the token is received from a trust source (like the workload API)
  2. ParseAndValidate - parses and validates the JWT-SVID token according to the spec and returns the SVID type.

This issue depends on #57 for validation.

@azdagron azdagron added this to To do in V2 API via automation Mar 9, 2020
@MarcosDY MarcosDY self-assigned this Mar 19, 2020
@MarcosDY MarcosDY moved this from To do to In progress in V2 API Mar 19, 2020
@MarcosDY MarcosDY moved this from In progress to Review in progress in V2 API Mar 26, 2020
@MarcosDY MarcosDY moved this from Review in progress to Reviewer approved in V2 API Mar 27, 2020
@MarcosDY MarcosDY moved this from Reviewer approved to Done in V2 API Apr 6, 2020
@azdagron
Copy link
Member Author

Fixed in #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
V2 API
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants