Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine the impact of custom plugin names #18

Open
edwbuck opened this issue Oct 28, 2023 · 0 comments
Open

Determine the impact of custom plugin names #18

edwbuck opened this issue Oct 28, 2023 · 0 comments

Comments

@edwbuck
Copy link
Collaborator

edwbuck commented Oct 28, 2023

In a custom plugin, the pattern is

plugins {
  <pluginType> <pluginName> {
     plugin_data {
         plugin_cmd = "/usr/bin/customKeyManager"
         plugin_checksum = "3f363c538588bbbbbcbe5374274c2c01f0d1387e012b68a22178e3dd790dc26c"
         enabled = true
         plugin_data {
            <stuff>
         }
     }
  }
}

Currently our custom plugins permit the user to set the custom plugin name.

The following items are not clear:

  • Should the name be specified by the user
  • Should the name be hardwired to "custom" or some other fixed string
  • Does the name have to match the custom plugin in some way

We should decide on which if the above policies is the correct one, document it, and adjust the charts to enforce the policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant