Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent and server log output could be improved during attestation #213

Closed
ajessup opened this issue Sep 30, 2017 · 0 comments · Fixed by #243
Closed

Agent and server log output could be improved during attestation #213

ajessup opened this issue Sep 30, 2017 · 0 comments · Fixed by #243
Assignees

Comments

@ajessup
Copy link
Member

ajessup commented Sep 30, 2017

When reading the logs of the spire-agent and spire-server during node attestation, it would be useful to be able to see the node attestation strategy employed by the agent.

For example, in the agent:

INFO[0000] Preparing to attest against %s127.0.0.1:8081
INFO[0000] Generating a CSR for %sspiffe://example.org/spiffe/node-id/NOT-A-SECRET
INFO[0000] Attestation complete

could be:

INFO[0000] Preparing to attest this node using strategy `join-token`
INFO[0000] Generating a CSR for spiffe://example.org/spiffe/node-id/NOT-A-SECRET
INFO[0000] Node attestation complete

And on the server, when a node is attested, instead of nothing in the logs, we could have something more informative such as:

INFO[0000] Received node attestation request from spiffe://example.org/spiffe/node-id/NOT-A-SECRET using strategy `join-token`... completed successfully. SVID issued with TTL=300s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants