Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Emoji Search Results #77

Closed
Spikeysanju opened this issue Oct 20, 2021 · 0 comments · Fixed by #78
Closed

Duplicate Emoji Search Results #77

Spikeysanju opened this issue Oct 20, 2021 · 0 comments · Fixed by #78
Assignees
@Spikeysanju
Labels
bug Something isn't working
Projects
Einsen
Milestone
v1.0.0-alpha02

Comments

@Spikeysanju
Copy link
Owner

Spikeysanju commented Oct 20, 2021 •
edited

Describe the bug
When searching for Emoji it returns multiple duplicate Emoji's

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Add Task Screen'
  2. Click on 'Emoji Picker'
  3. Search for Emoji
  4. See error

Expected behavior
Search results should not contain Duplicate Emoji's

Smartphone Details (please complete the following information):

  • Poco F1
  • Android 11

Additional context
We can fix this error by adding distinct() filter on EmojiResults in ViewModel
@Spikeysanju Spikeysanju added the bug Something isn't working label Oct 20, 2021
@Spikeysanju Spikeysanju added this to the v1.0.0-alpha02 milestone Oct 20, 2021
@Spikeysanju Spikeysanju self-assigned this Oct 20, 2021
@Spikeysanju Spikeysanju added this to To do in Einsen via automation Oct 20, 2021
@Spikeysanju Spikeysanju moved this from To do to In progress in Einsen Oct 20, 2021
Spikeysanju added a commit that referenced this issue Oct 20, 2021
@Spikeysanju
Fix Duplicate Emoji on Search Results #77
676e433 
Signed-off-by: Sanju S <spikeysanju98@gmail.com>
Spikeysanju added a commit that referenced this issue Oct 20, 2021
@Spikeysanju
Merge pull request #78 from Spikeysanju/Fix-Duplicate-Emoji
263983d 
Fix `Duplicate Emoji` on `Search Results` #77
@Spikeysanju Spikeysanju linked a pull request Oct 20, 2021 that will close this issue
Fix Duplicate Emoji on Search Results #77 #78
Merged
Einsen automation moved this from In progress to Done Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Spikeysanju Spikeysanju

Labels
bug Something isn't working
Projects
Einsen
Done
Einsen
Status: Done
Milestone
v1.0.0-alpha02
Development

Successfully merging a pull request may close this issue.

Fix Duplicate Emoji on Search Results #77 Spikeysanju/Einsen
1 participant
@Spikeysanju