Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fig_t1_t2_agreement.png same as fig_t1_t2_agreement_per_vendor.png #68

Open
6 tasks
valosekj opened this issue May 31, 2020 · 2 comments
Open
6 tasks
Assignees

Comments

@valosekj
Copy link
Contributor

After changes in fig_t1_t2_agreement_per_vendor.png figure, I assume it would be nice to adjust fig_t1_t2_agreement.png to looks alike.

fig_t1_t2_agreement_small

Possible improvements I noticed up to now:

  • move grid to background
  • increase title size
  • adjust x- and y-axis limits to be dynamic (now they are fixed)
  • decrease spacing between symbol and vendor name in legend
  • change transparency of legend box (now grid is visible)
  • change color of legend box's frame to black
@valosekj valosekj self-assigned this May 31, 2020
@jcohenadad
Copy link
Member

@valosekj given the strong overlap between this figure and the vendor-specific figure, i am wondering if we should keep maintaining it. For the article, i am thinking of only including the vendor-specific one.

@valosekj
Copy link
Contributor Author

valosekj commented Jun 1, 2020

@jcohenadad okay. So I let this figure in current stage and we will know what to improve if we need it once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants