Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base alternative can be purged #327

Closed
soininen opened this issue Dec 13, 2023 · 4 comments
Closed

Base alternative can be purged #327

soininen opened this issue Dec 13, 2023 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@soininen
Copy link
Collaborator

Currently, we protect the 'Base' alternative: it cannot be removed from the database. However, when purging alternatives, also alternative id 1 (i.e. 'Base') gets purged.

This is a non-issue if we lift the protection as suggested in spine-tools/Spine-Toolbox#2331

@soininen soininen added bug Something isn't working 0.8 labels Dec 13, 2023
@soininen soininen added this to the v0.8.0 milestone Dec 13, 2023
@jkiviluo
Copy link
Member

We shouldn't enforce a particular base alternative name. It's hard coding. For example, sometimes user may have two equal bases 'north' and 'south'. One adds a north part of the model and the other south part, but there is no common base. And I don't necessarily want to call my base 'Base', I might want to call it e.g. 'init'.

@soininen
Copy link
Collaborator Author

soininen commented Dec 14, 2023

In case of removal, we actually protect the alternative id, not its name so we aren't hard-coding anything except the existence of at least one alternative. Anyway, this issue is not about whether we should have that guarantee. Rather, it is about a bug if we choose to keep the guarantee.

@jkiviluo
Copy link
Member

I think this is to be discussed in the next Toolbox telco.

@soininen
Copy link
Collaborator Author

soininen commented Apr 9, 2024

It was decided in the 2024-04-09 developer meeting that we will allow deletion of the 'Base' alternative.

@soininen soininen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants