Parameter table names

[spine-o-bot]

In GitLab by @jkiviluo on Oct 26, 2018, 14:32

parameter and parameter_value tables have somewhat confusing names. 'parameter' sounds like it would contain the values too. When we make changes to the DB structure (e.g. with archetype/feature/method) it might be a good chance to also update this.

I would suggest to use parameter_definition and parameter_value as table names.

[spine-o-bot]

In GitLab by @manuelma on Jan 25, 2019, 21:18

mentioned in commit 0e05275

[spine-o-bot]

In GitLab by @manuelma on Jan 25, 2019, 21:19

This is now implemented and tested.

[spine-o-bot]

In GitLab by @manuelma on Jan 25, 2019, 21:19

closed

[spine-o-bot]

In GitLab by @manuelma on Jan 31, 2019, 14:45

reopened

[spine-o-bot]

In GitLab by @manuelma on Jan 31, 2019, 14:49

Actually we may need to do one more thing. Now I just renamed the table but didn't touch the API, so that clients won't note the difference. But I think we need to homogenize the name everywhere and that means modifying the API and updating the clients as well, toolbox and model. It's a lot of 'search and replace' work, but I think we need to do it. @PvPer

[spine-o-bot]

In GitLab by @manuelma on Feb 4, 2019, 20:16

mentioned in commit dd50307

[spine-o-bot]

In GitLab by @manuelma on Feb 8, 2019, 17:36

mentioned in commit b7918e8

[spine-o-bot]

In GitLab by @manuelma on Feb 8, 2019, 17:43

mentioned in commit 1f1e74c

[spine-o-bot]

In GitLab by @manuelma on Feb 8, 2019, 17:46

mentioned in commit c06553f

[spine-o-bot]

In GitLab by @manuelma on Feb 19, 2019, 21:06

mentioned in commit 32f5085

[spine-o-bot]

In GitLab by @manuelma on Feb 22, 2019, 14:09

mentioned in commit 1b87ca2

[spine-o-bot]

In GitLab by @manuelma on May 30, 2019, 19:11

This is still pending. But here's a question: is it ok to just change exported names and adapt our API clients so it works, without caring about the outside world?

I have so far avoided this, by issuing deprecation warnings in methods whose name I want to change (eg. add_parameter method to add_parameter_definition)

My plan is to let some time pass and then change the name. But maybe I'm being too conservative.

[spine-o-bot]

In GitLab by @jkiviluo on Jun 3, 2019, 12:21

If you do the changes, everybody just needs to update into the latest versions of DB and API at the same time? I think that should be ok still - just let people know in Slack.

[spine-o-bot]

In GitLab by @manuelma on Jun 5, 2019, 23:46

mentioned in commit 3a8f95b

[spine-o-bot]

In GitLab by @manuelma on Jun 5, 2019, 23:47

mentioned in commit toolbox@8286a6f20ed81a23d4f78726dcc95f9969c73e66

[spine-o-bot]

In GitLab by @manuelma on Jun 5, 2019, 23:47

mentioned in commit SpineInterface.jl@3f1981f4771ef462a45196a0ecfd0059cedc18ca

[spine-o-bot]

In GitLab by @manuelma on Jun 6, 2019, 00:11

mentioned in commit toolbox@0715e8dfc2c85f27567473b78851219f1be9a88a

[spine-o-bot]

In GitLab by @manuelma on Jun 6, 2019, 00:11

mentioned in commit 21ebf5d

[spine-o-bot]

In GitLab by @manuelma on Jun 6, 2019, 00:15

mentioned in commit toolbox@c50d97e6d4b3abadefff1e4216ff227375b93739

[soininen]

The tables have been renamed.