Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spinedatabase_api package to something shorter #27

Closed
spine-o-bot opened this issue Feb 3, 2021 · 16 comments
Closed

Rename spinedatabase_api package to something shorter #27

spine-o-bot opened this issue Feb 3, 2021 · 16 comments
Assignees
Labels

Comments

@spine-o-bot
Copy link

In GitLab by @manuelma on Oct 26, 2018, 23:18

I'm getting tired of writing spinedatabase_api, I think we could rename the package to spine_dbapi?

Means updating a couple of READMEs too.

@PekkaSavolainen

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Oct 27, 2018, 12:27

changed title from Rename package to something shorter to Rename {+spinedatabase_api +}package to something shorter

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 25, 2019, 17:48

I'm starting to think it's already too late for this one...

@spine-o-bot
Copy link
Author

In GitLab by @PekkaSavolainen on Mar 26, 2019, 12:45

Yeah, database should have been db from the get go. Would it really be a big change though? We just need to rename spinedatabase_api -> spine_dbapi on the toolbox side. There's 48 matches of spinedatabase_api in the code base and most are in comments anyway.

Is spine_dbapi the best alternative? Maybe. spinedbapi is not that readable. spine_db_api is cumbersome. spinedb_api is basically the same as your suggestion.

@spine-o-bot
Copy link
Author

In GitLab by @PekkaSavolainen on Mar 26, 2019, 12:47

assigned to @manuelma

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 14:57

mentioned in commit 5480469

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:05

mentioned in commit f50ce96

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:12

mentioned in commit a9c5eda

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:14

mentioned in commit toolbox@d5fb30ca18d4320b7dc88f8c4202b5f6de9f3a09

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:41

mentioned in commit f53358e

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:44

mentioned in commit toolbox@2b88c43d6afd6f0f40ea43dd8906010018df1c23

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 15:48

mentioned in commit toolbox@11ef638d75b864d125978327be5e80c89a15c481

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 26, 2019, 16:17

mentioned in commit 27fa5a4

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 27, 2019, 14:32

mentioned in commit SpineInterface.jl@2925d0193ae4e37e6814ba4106ec91ba63da5dcd

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Mar 29, 2019, 13:04

Does this work? Keeping this issue open so people can report problems.

@spine-o-bot
Copy link
Author

In GitLab by @PekkaSavolainen on Apr 2, 2019, 10:27

It works.

FYI. If you want to tidy up your Python environment, you can uninstall the old spinedatabase_api package. But keep in mind that other branches (other than dev) in Toolbox may still require it.

@spine-o-bot
Copy link
Author

In GitLab by @manuelma on Apr 4, 2019, 15:19

closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants