-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs failing #2342
Comments
We should also duplicate the docs/requirements.txt from spinetoolbox to spinedb-api side. |
- Set language = "en" to prevent a warning - Add builder: html just in case Re spine-tools/Spine-Toolbox#2342
Now docs/requirements.txt on both toolbox and spinedb-api branches 0.8-dev and master are compatible with Spine Toolbox requirements. Bottom line is that the newest Sphinx version we can use is 5.1.1 until we support a more recent dagster version.
|
Yesterday, It looks like I left sphinx.ext.viewcode enabled on spinedb-api side when I was supposed to disable it (in commit spine-tools/Spine-Database-API@eea4e31). I thought enabling it was going to crash the CI on readthedocs.org but to my surprise it actually passed. After that commit there's been a few updates to that part of the code, so I tried running build_docs locally in commit spine-tools/Spine-Database-API@9e4f5eb. It gives me this error
But it looks like this commit passes on readthedocs.org. When I comment out functions So, the question is @manuelma, did you notice that the refactoring done in DatabaseMapping and it's inherited members probably fixed the build_doc build process with viewcode enabled and there seems to be no need for those 3 added functions in conf.py? Or are you still working on this? EDIT |
Sorry @PekkaSavolainen I forgot to tell you. I removed the "inherited-members" option and restablished viewcode. I don't need "inherited-members" anymore. Yes, it's cool, I'll take care of it. Thank you! |
Building the docs now works on both spinetoolbox and spinedb-api so I'm closing this issue. |
Building the docs locally and on readthedocs.org have been failing for a week now in 0.8-dev branch. Most likely they will fail in master branch the next time they are built.
The text was updated successfully, but these errors were encountered: