-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide if spin-operator should be a global or namespaced operator #142
Comments
Global Operator + Global Executors I think would be my preference as a plan to move forwards - CRDs being global means namespaced operators are somewhat annoying to manage wrt version handling. Executors being namespaced are a little bit awkward because RuntimeClasses are global. |
I think the current state of this means for launch we're doing Namespaced executors, and a plan for switching to global will be:
|
@endocrimes would we have to change the name? Could we just bump |
+1 to global operator and global executor. There will be folks who want to configure per namespace. We should figure out how to do that down the line if that's desirable but it'd be great if by default these were global.
I'd be in favor of taking this opportunity to make the name shorter. |
It sounds to me like we're building consensus around the steps:
I'll leave this issue open for another day or two to give people (CC @bacongobbler) to chime in if they want with different opinions. Then if we still have consensus by then I'll close this issue and open some new issues to track the work in the steps above. |
Sounds good to me! I don't think this work would affect |
I increasingly strongly feel like SpinAppExecutor should stay namespaced, but I wouldn't necessarily be opposed to a SpinAppExecutor in the same-namespace-as-the-operator being treated as the global defaults (as much as it's a bit weird, and would be hard to debug, and not really recommended) The executor is a combination of binding to global config |
Currently the
spin-operator
acts globally (you can apply yourSpinApp
s into any namespace). But, ourSpinAppExecutor
s are namespaced (they need to be in the same namespace as yourSpinApp
).We need to decide if we want the
spin-operator
to be a global or namespaced operator.The text was updated successfully, but these errors were encountered: