Add podServiceAccountName to SpinApp CRD #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes spinkube#226 Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
ThorstenHans
requested review from
calebschoepp,
endocrimes,
bacongobbler and
michelleN
as code owners
michelleN
reviewed
May 8, 2024
There was a problem hiding this comment.
Code looks good to me @ThorstenHans and seems like this a reasonable addition.
What does the failure scenario look like when a service account with the provided name doesn't exist?
@michelleN that's a good question. When a user tries to create a Pod and is referencing a non-existing ServiceAccountName, the Pod is not accepted at all and a corresponding error message is presented to the user. I would prefer our controller also checking for the specified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, users are able to specify the
ServiceAccountNamefor underlying podscloses #226