Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching agent methods are confusing #3

Open
claymccoy opened this issue Jun 4, 2020 · 0 comments
Open

Caching agent methods are confusing #3

claymccoy opened this issue Jun 4, 2020 · 0 comments
Labels

Comments

@claymccoy
Copy link
Contributor

Looking at the code, it isn't clear what exactly the differences are in CachingAgent and OnDemandAgent or what these methods are supposed to do. handles vs pendingOnDemandRequests are similar and the purpose of each is not clear. That latter has a confusing name.

override fun pendingOnDemandRequests(providerCache: ProviderCache) : Collection<Map<String, Any>> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant