Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only display the secret to stdout if we are able to parse it as UTF-8? #9

Open
romac opened this issue Aug 2, 2017 · 0 comments
Open

Only display the secret to stdout if we are able to parse it as UTF-8? #9

romac opened this issue Aug 2, 2017 · 0 comments
Labels
question

Comments

@romac
Copy link
Member

romac commented Aug 2, 2017 •
edited
Loading

It would be nice if we could detect that we are printing to the console and not redirecting to a file, and only validate the output then, as we might want to let user redirect/piping the standard output even if it's not printable.
romac added a commit that referenced this issue Aug 2, 2017
@romac
Output secret directly to stdout without parsing it as UTF-8 first. See
167a8a3 
#9
@romac romac changed the title Should we only display the secret to stdout if we are able to parse it as UTF-8? Only display the secret to stdout if we are able to parse it as UTF-8? Aug 3, 2017
@romac romac added the question label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romac