Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creatives = 0 (no creativity) does not pass in the value (resulting in NaN values later) #34

Open
Kermalis opened this issue Jun 29, 2021 · 0 comments

Comments

@Kermalis
Copy link

The return object here is expecting a .values property which is passed in from the parameter: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160

However, when creatives is 0, you are just mapping the array without adding .values to it: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160

The return object for creativity != 0 adds .values properly: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160

The return value is then used in Markov. However, .values is never used, so I'm not sure what the point of it is. The input value comes from Associate when it generates avalues, which is currently broken (#32)
So why does associate generate values if they won't be used? The pairing formula in associate doesn't shed any light on what the values are for.

@Kermalis Kermalis changed the title Creatives = 0 (no creativity) does not pass in the value (resulting in NaN used everywhere after) Creatives = 0 (no creativity) does not pass in the value (resulting in NaN values later) Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant