You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The return value is then used in Markov. However, .values is never used, so I'm not sure what the point of it is. The input value comes from Associate when it generates avalues, which is currently broken (#32)
So why does associate generate values if they won't be used? The pairing formula in associate doesn't shed any light on what the values are for.
The text was updated successfully, but these errors were encountered:
Kermalis
changed the title
Creatives = 0 (no creativity) does not pass in the value (resulting in NaN used everywhere after)
Creatives = 0 (no creativity) does not pass in the value (resulting in NaN values later)
Jun 29, 2021
The return object here is expecting a
.values
property which is passed in from the parameter: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160However, when creatives is 0, you are just mapping the array without adding
.values
to it: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160The return object for creativity != 0 adds
.values
properly: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160The return value is then used in Markov. However,
.values
is never used, so I'm not sure what the point of it is. The input value comes from Associate when it generates avalues, which is currently broken (#32)So why does associate generate values if they won't be used? The pairing formula in associate doesn't shed any light on what the values are for.
The text was updated successfully, but these errors were encountered: