New Click Command #1114
Open
New Click Command #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options. Added tests as well.
Glandos
requested changes
Jan 28, 2023
There was a problem hiding this comment.
I've added some small Pythonic changes.
But globally, it would better to have a list of predicates to filter the list of project, and execute this list comprehension project = [] only once.
I bet this is possible with SQLAlchemy, but don't have the time to find it, so, it will be fine for me with Python lambdas :)
Comment on lines
+134
to
+137
| if bills_high < bills_low: | ||
| temp = bills_high | ||
| bills_high = bills_low | ||
| bills_low = temp |
There was a problem hiding this comment.
Suggested change
| if bills_high < bills_low: | |
| temp = bills_high | |
| bills_high = bills_low | |
| bills_low = temp | |
| if bills_high < bills_low: | |
| (bills_low, bill_high) = bills_high, bills_low |
Comment on lines
+143
to
+144
| if pr.get_bills().count() >= bills_low | ||
| and pr.get_bills().count() <= bills_high |
There was a problem hiding this comment.
Suggested change
| if pr.get_bills().count() >= bills_low | |
| and pr.get_bills().count() <= bills_high | |
| if bills_low <= pr.get_bills().count() <= bills_high |
Comment on lines
+181
to
+187
| click.echo(len(projects)) | ||
| if emails: | ||
| list_emails = ", ".join(set([pr.contact_email for pr in projects])) | ||
| click.echo(list_emails) | ||
| if names: | ||
| proj_names = [pr.name for pr in projects] | ||
| click.echo(proj_names) |
There was a problem hiding this comment.
This is duplicated code from line 155-161.
|
Also, maybe a default value of 0 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Click command to display the number of projects. Options exist to specify for projects within the bounds of the specified number of bills (inclusive) and/or less than x days old.