Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfile to setup the app at build time instead of runtime #792

Closed
wrecker opened this issue Jul 12, 2021 · 3 comments
Closed

Change Dockerfile to setup the app at build time instead of runtime #792

wrecker opened this issue Jul 12, 2021 · 3 comments
Milestone

Comments

@wrecker
Copy link
Contributor

wrecker commented Jul 12, 2021

The current Dockerfile is written to download the python dependencies and setup the full app when the container starts up. This means everytime the container starts up it goes the whole process of downloading the python dependencies from PyPi and setting up the app. I was trying to bring this up in an isolated environment and realized it wouldn't work. There are other side-effects like users cannot run the generate_hashed_password with a built image in a single step.

A better way to do this would be move the python setup process from entrypoint.sh into the Dockerfile and simplify the entrypoint.sh (and in turn the startup process). If the current behavior is useful for dev purposes, the project can have a separate Dockerfile.dev with a corresponding dev-entrypoint.sh.

@wrecker
Copy link
Contributor Author

wrecker commented Jul 12, 2021

I have a PR if you would like to see & review my changes.

@zorun
Copy link
Collaborator

zorun commented Jul 12, 2021

Hi, welcome! This is definitely a change we want to have, I also don't like the current process (but I'm not a big Docker user). I'll comment on the PR.

For reference, we have another issue about Docker here: #332

@zorun zorun added this to the v5 milestone Jul 14, 2021
@ra-ju
Copy link

ra-ju commented Jul 14, 2021

Since the PR #793 has been merged, can we close this issue?

@zorun zorun closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants