Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed linters warnings, add gomodules support, function optimization #35

Merged
merged 5 commits into from Nov 29, 2019
Merged

Fixed linters warnings, add gomodules support, function optimization #35

merged 5 commits into from Nov 29, 2019

Conversation

rustatian
Copy link
Member

  • Updated travis to support go 1.13
  • Updated tests (errors handling, simplify)
  • Add go modules support
  • Optimize pack function

@rustatian
- Updated travis to support go 1.13
8a908b3 
- Updated tests (errors handling, simplify)
- Add go modules support
- Optimize pack function
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 49.148% when pulling 9b23ad5 on ValeryPiashchynski:Fixed_linter_warnings_optimize_pack_function into 8d98395 on spiral:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 49.24% when pulling 9b23ad5 on ValeryPiashchynski:Fixed_linter_warnings_optimize_pack_function into 8d98395 on spiral:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 49.24% when pulling 9b23ad5 on ValeryPiashchynski:Fixed_linter_warnings_optimize_pack_function into 8d98395 on spiral:master.

@rustatian rustatian marked this pull request as ready for review November 25, 2019 17:07
wolfy-j
wolfy-j approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@wolfy-j wolfy-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go.

@wolfy-j wolfy-j merged commit d339ea3 into roadrunner-server:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy-j wolfy-j wolfy-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rustatian @coveralls @wolfy-j