Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .ogg and .flac and transcoding? #5

Closed
andrenam opened this issue Sep 21, 2013 · 4 comments
Closed

Support for .ogg and .flac and transcoding? #5

andrenam opened this issue Sep 21, 2013 · 4 comments

Comments

@andrenam
Copy link
Contributor

Hi spl0k,

I was very happy when I found your project and I'm using it on my raspberry pi now.
I'm playing around with it and started to work on support for .ogg and .flac files and on transcoding using ffmpeg/libav. I've got it partially working on archlinux but it needs testing. Are you interested in a patch/pull request? Maybe we can work together?

And another question: what license do you want to use for supysonic?
GPL, Apache, MIT, ... ?

@spl0k
Copy link
Owner

spl0k commented Sep 23, 2013

Yeah, feel free to do any pull request :)

Didn't thought about the license. I don't know which one allows what and I feel kinda lost in all this legal mumbo jumbo.

@spl0k
Copy link
Owner

spl0k commented Oct 15, 2013

22e2d35 + 2d0774a
I'll write the doc about transcoding configuration later.

@spl0k spl0k closed this as completed Oct 15, 2013
@andrenam
Copy link
Contributor Author

Hi, nicely done. Very flexible system. 👍
I see one problem with scanner.py though. Mutagen cannot determine a bitrate for flac files.

tr.bitrate  = tag.info.bitrate / 1000

will not work for flac files. But supysonic needs the bitrate information in api/media.py to compare it with maxBitrate to decide if transcoding is necessary. Please have a look at how I did that: andrenam@5081daf

# estimation: filesize in kbit / length
tr.bitrate = int(((os.path.getsize(path)*8)/1000) / tag.info.length)

@spl0k
Copy link
Owner

spl0k commented Oct 16, 2013

Oh I wasn't aware of that, thanks. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants