Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DGS Densification Config for SplaTAM #38

Open
Ramseyous0109 opened this issue Dec 19, 2023 · 5 comments
Open

3DGS Densification Config for SplaTAM #38

Ramseyous0109 opened this issue Dec 19, 2023 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Ramseyous0109
Copy link

Hi, thanks for this brilliant work.
I came across a bug running an offline demo on the replica dataset. I found that in the config file, use gaussian splatting-based densification is set to false:

use_gaussian_splatting_densification=False, # Use Gaussian Splatting-based Densification during Mapping

When I set this config to True, a bug appeared when training:

File "/home/user/splatam/SplaTAM/utils/slam_external.py", line 101, in accumulate_mean2d_gradient    variables['means2D_gradient_accum'][variables['seen']] += torch.norm(IndexError: The shape of the mask [853079] at index 0 does not match the shape of the indexed tensor [853064] at index 0

And this shape mismatch error can be reproduced in other dataset demos.

@pengchongH
Copy link

Same problem.

Thanks for your work. I also would like to know whether setting use_gaussian_splatting_densification=False means that we don't split the 3D gaussian.

@Nik-V9
Copy link
Contributor

Nik-V9 commented Dec 26, 2023

Hi, Thanks for your interest in our work!

We don't use the official 3DGS Densification in SplaTAM. We don't currently support the use_gaussian_splatting_densification config. It was used in an old version of our code. We will try to fix this bug.

@Nik-V9 Nik-V9 added bug Something isn't working enhancement New feature or request labels Dec 26, 2023
@Nik-V9 Nik-V9 changed the title Bug when setting the config use_gaussian_splatting_densification=True 3DGS Densification Config for SplaTAM Dec 26, 2023
@Ramseyous0109
Copy link
Author

I get it. Thanks for your reply anyway!

@pengchongH
Copy link

Thanks for your reply!

@Buffyqsf
Copy link

Hello guys, I've meet a similar request. I haven't tried to run this densification strategy. But after reading the code, I don't know why this would happen. Have you fixed this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants