Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switching occurs with a delay #47

Closed
denisgl7 opened this issue Oct 7, 2023 · 7 comments · Fixed by #48
Closed

Theme switching occurs with a delay #47

denisgl7 opened this issue Oct 7, 2023 · 7 comments · Fixed by #48
Assignees
Labels
enhancement New feature or request

Comments

@denisgl7
Copy link

denisgl7 commented Oct 7, 2023

2023-10-07.13.44.08.mov

When changing the theme, rebuilding will not cause the colors to change immediately

@maeddin
Copy link
Member

maeddin commented Oct 7, 2023

@denisgl7 My current approach is not tested at all. Therefore I would be very happy about your feedback.
There is now the new parameter animateThemeChanges. Alternatively, you can now set styleAnimationType and indicatorAnimationType to AnimationType.none.

animated_toggle_switch:
    git:
      url: https://github.com/splashbyte/animated_toggle_switch.git
      ref: 47-theme-switching-delay

@maeddin maeddin self-assigned this Oct 7, 2023
@maeddin maeddin added the enhancement New feature or request label Oct 7, 2023
@maeddin
Copy link
Member

maeddin commented Oct 7, 2023

I might remove animateThemeChanges again in favor of the new CustomToggleStyle.

@denisgl7
Copy link
Author

denisgl7 commented Oct 7, 2023

CustomToggleStyle perfect work!!

2023-10-07.17.46.18.mov

@maeddin
Copy link
Member

maeddin commented Oct 12, 2023

@denisgl7 In retrospect, I think that no update would have been necessary. Can you try again if it works without CustomToggleStyle if you set styleAnimationType: AnimationType.onSelected?

@denisgl7
Copy link
Author

I checked - this solution does not work. The style change occurs as in the video in the first message

@maeddin
Copy link
Member

maeddin commented Oct 12, 2023

My fault: styleAnimationType: AnimationType.onHover. Sorry 😅

@maeddin
Copy link
Member

maeddin commented Oct 13, 2023

@denisgl7 Does it work with styleAnimationType: AnimationType.onHover?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants