Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spline "Physical" material shader not compiled in three@0.157 #21

Open
pierusan opened this issue Oct 16, 2023 · 1 comment
Open

Spline "Physical" material shader not compiled in three@0.157 #21

pierusan opened this issue Oct 16, 2023 · 1 comment

Comments

@pierusan
Copy link

When I create a new Spline scene, add a cube, and change its material lighting from Phong to Physical, the exported r3f Scene will not render. The error message in the console says:

THREE.WebGLProgram: Shader Error 0 - VALIDATE_STATUS false

ERROR: 0:1255: 'geometryNormal' : undeclared identifier
ERROR: 0:1255: 'geometryNormal' : undeclared identifier
ERROR: 0:1255: '=' : dimension mismatch
ERROR: 0:1255: '=' : cannot convert from 'highp float' to 'highp 3-component vector of float'

Spline scene with cube: https://my.spline.design/bugpbr-697c24bb953fb9261036866a8faaeb80/

Codesandbox with the error: https://codesandbox.io/s/r3f-spline-pbr-bug-7d2mgc

In the sandbox I also added a Scene1 component, which is the scene from the Spline demo referenced in the Readme. If you render Scene1 instead of Scene2, you'll also see that the demo suffers from shader issues with three@0.157.

@danhollick
Copy link

I've hit this same issue with the Glass material shader.
It seems like maybe geometryNormal was renamed at some point and this line wasn't updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants