Skip to content

Commit

Permalink
Insertion of current namespace in Media Manager tree list
Browse files Browse the repository at this point in the history
As the $data sort order has been fixed in search() (see "search.php"), utf8_encodeFN() must not be used in the comparison.
  • Loading branch information
moisesbr-dw committed May 21, 2020
1 parent 8371b18 commit aa422a5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 1 addition & 4 deletions inc/media.php
Expand Up @@ -1981,10 +1981,7 @@ function media_nstree($ns){
while ($data[$pos]['id'] != $tmp_ns) {
if (
$pos >= count($data) ||
(
$data[$pos]['level'] <= $level+1 &&
strnatcmp(utf8_encodeFN($data[$pos]['id']), utf8_encodeFN($tmp_ns)) > 0
)
($data[$pos]['level'] <= $level+1 && intl_strcmp($data[$pos]['id'], $tmp_ns) > 0)
) {
array_splice($data, $pos, 0, array(array('level' => $level+1, 'id' => $tmp_ns, 'open' => 'true')));
break;
Expand Down
2 changes: 2 additions & 0 deletions inc/sort.php
Expand Up @@ -47,6 +47,8 @@ function _get_collator() {
// lib/plugins/acl/admin.php:307
// strcasecmp()
// inc/Ui/Admin.php:162
// strnatcmp()
// inc/media.php:1986 --> 1984
/**
* Drop-in replacement for strcmp(), strcasecmp(), strnatcmp() and strnatcasecmp().
* It uses a collator-based comparison, or strnatcasecmp() as a fallback.
Expand Down

0 comments on commit aa422a5

Please sign in to comment.