Merge pull request #2660 from splitbrain/issue-2647

don't show empty optiongroup item in Mobilemenu
dokuwiki · Jan 8, 2019 · d4af363 · d4af363
2 parents 3c6f8fa + 5940772
commit d4af363
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/inc/Menu/MobileMenu.php b/inc/Menu/MobileMenu.php
@@ -70,14 +70,16 @@ public function getDropdown($empty = '', $button = '&gt;') {
         $html .= '<option value="">' . $empty . '</option>';
 
         foreach($this->getGroupedItems() as $tools => $items) {
-            $html .= '<optgroup label="' . $lang[$tools . '_tools'] . '">';
-            foreach($items as $item) {
-                $params = $item->getParams();
-                $html .= '<option value="' . $params['do'] . '">';
-                $html .= hsc($item->getLabel());
-                $html .= '</option>';
+            if (count($items)) {
+                $html .= '<optgroup label="' . $lang[$tools . '_tools'] . '">';
+                foreach($items as $item) {
+                    $params = $item->getParams();
+                    $html .= '<option value="' . $params['do'] . '">';
+                    $html .= hsc($item->getLabel());
+                    $html .= '</option>';
+                }
+                $html .= '</optgroup>';
             }
-            $html .= '</optgroup>';
         }
 
         $html .= '</select>';