Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mbstring dependency causes broken links after upgrading to Hogfather #3113

Closed
CyanBlob opened this issue Jun 1, 2020 · 16 comments
Closed
Labels

Comments

@CyanBlob
Copy link

CyanBlob commented Jun 1, 2020

Hey everyone!

I just recently upgraded to Hogfather from version 18, and now see that I've got broken links throughout my wiki.

After looking into it, I realized that in the previous version, links such as [[players:bruce]] and [[players:Bruce]] would link to the same page (case insensitive). Now, however, they point to different pages.

Additionally, links like [[places:Bruce's Library]] are now broken as well, requiring me to change them to [[places:bruce_s_library]]. It seems that links must now match the "sanitized" page names instead of the actual name.

Was something changed with how link locations are resolved?

@CyanBlob
Copy link
Author

CyanBlob commented Jun 1, 2020

Here's a screenshot showing the issue:
link_issue

@drabels
Copy link

drabels commented Jun 2, 2020

Just experienced precisely the same issue today attempting to upgrade from Greebo to Hogfather. Reverting to Greebo and then deleting the cache files let's me continue my work (i.e. Wiki links are now functional again), but it would be good to understand what's causing the problem in this release.

@Klap-in
Copy link
Collaborator

Klap-in commented Jun 2, 2020

Sounds like a broken or missing pieces in the download package, at the first sight.
Are there any errors in the log of the webserver?

How did you perform the upgrade? which package or which approach?

@splitbrain
Copy link
Collaborator

I can not reproduce this either and I am a bit stumped how this should even happen. In addition to the things @Klap-in asked about, please also give info about this:

  • operating system and filesystem used
  • any settings related to links (camelcase, autoplural, etc.)
  • installed plugins that might influence link handling
  • PHP version
  • if the mbstring PHP extension is available

@spamik
Copy link

spamik commented Jun 2, 2020

Happend to me as well. mbstring extension was missing, after installing it and restarting apache it seems it's working. Well, without one exception - I had some links like this: [[somens:somepage:]] which resulted in link [[somens:somepage:start]]. Now if I leave this the whole link disappear from page. If I rewrite it to [[somens:somepage:start]] it works.

@CyanBlob
Copy link
Author

CyanBlob commented Jun 2, 2020

I can confirm that @spamik's solution fixed the issue for me as well! I followed the instructions here to install it.

For the record, I upgraded to Hogfather from the Dokuwiki Upgrade plugin. This was on Raspbian 9 (ARM, on a Raspberry Pi) on an ext4 filesystem with PHP 7.0.

@CyanBlob
Copy link
Author

CyanBlob commented Jun 2, 2020

Did Hogfather introduce a dependency on mbstring? Or could the upgrade process have removed it?

@CyanBlob CyanBlob changed the title Broken links after upgrading to Hogfather Missing mbstring dependency causes broken links after upgrading to Hogfather Jun 2, 2020
@splitbrain
Copy link
Collaborator

I'm still having trouble reproducing this. I can't easily disable mbstring because my PHP has it compiled in, but I switched the UTF8_MBSTRING constant and I see our fallback mechanisms used just as they should.

DokuWiki should continue to work without mbstring, so the behaviour you're seeing is definitively a bug of some kind.

@splitbrain splitbrain added the Bug label Jun 2, 2020
splitbrain added a commit that referenced this issue Jun 2, 2020
This readds a whole bunch of conversions that for some reason got lost
in the refactoring. No idea what happened there.
@mjlush
Copy link

mjlush commented Jun 2, 2020

I'm getting this (Raspbian buster PHP 7.3.11-1~deb10u1)
It's a strange bug.. I have a link text as
[[nu-men:The Tabley Big Table of Connections]]
but in the page is rendered as
nu-men:the_tabley_Big_table_of_Connections

I'd be willing to provide a login to my system via teamviewer

@splitbrain
Copy link
Collaborator

I found the problem. For some reason the conversion table was missing a whole bunch of characters. Not sure what happend there. We'll have a fix out soon.

@drabels
Copy link

drabels commented Jun 3, 2020

I can confirm that installing mbstring fixed the issue for myself as well. I'm using Debian 10 and php 7.3. I just ran "apt-get install php-mbstring" and then restarted apache2. Then I upgraded dokuwiki via the plugin. All good now! Edit: Whoops, I now see this is acknowledged as a dependency. Thanks for the help/tips guys!

@phy25
Copy link
Collaborator

phy25 commented Jun 3, 2020

I believe this should have been fixed in master/snapshot by 0884c25, if you would like to give it a try.

Do we keep this open until a new RC is released, or until the fix is verified on master?

@Sperows
Copy link

Sperows commented Jun 3, 2020

Had same issue on CentOS Linux release 7.8.2003 (Core), installed mbstring and it started to work.

@phy25
Copy link
Collaborator

phy25 commented Jun 3, 2020

I am going to close this issue since it should have been fixed in RC2. Please comment if it still does not work for you in RC2.

@phy25 phy25 closed this as completed Jun 3, 2020
@CyanBlob
Copy link
Author

CyanBlob commented Jun 3, 2020

I upgraded to RC2, removed mbstring, and restarted Apache. I can confirm that RC2 is working as expected! Thanks for the quick turnaround everyone!

@mjlush
Copy link

mjlush commented Jun 3, 2020

I've just updated toRelease rc2-2020-06-01 "Hogfather" RC2 and all is back to normal

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants