Fix for #1360 - Enhance the row_counter

[svoboro1]

Fix for #1360 - Enhance the row_counter, please review.

[scrutinizer-notifier]

The inspection completed: 2 new issues

[Klap-in]

At line 1293 in function table_open() the row_counter is already initialized
Does that code nothing?
Or is that function never called for your specific case?

// initialize the row counter used for classes
         $this->_counter['row_counter'] = 0;

[Klap-in]

https://github.com/lupo49/dokuwiki-plugin-dir/blob/master/syntax.php#L1066
As #1360 notes, the table_open is redefined. It sets the _counter[row_counter] from this new function, but since that property is protected, it could not be changed by the new open_tabel function.

/** @var array global counter, for table classes etc. */
    protected $_counter = array(); //

[michitux]

Does this also work with multiple tables? I suspect that then the row counter is never reset...

I think a better fix would be to make it possible to specify css class(es) in table_open() (and similar renderer methods) such that plugins that want to use their own table style can still use the renderer methods that properly initialize everything.

[splitbrain]

is this obsolete with #1558? Can it be closed?

[Klap-in]

Thanks for the pull request, but #1558 solves this issue indeed by allowing adding classes to opening tags.

So plugins that didn't use DokuWiki's table_open(), but a modified copy, can now use the table_open() again since last DokuWiki release for adding a class to the opening tag.