Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed hash algo in install.php from smd5 to bcrypt #3158

Merged
merged 2 commits into from Jun 30, 2020
Merged

changed hash algo in install.php from smd5 to bcrypt #3158

merged 2 commits into from Jun 30, 2020

Conversation

ms101
Copy link
Contributor

@ms101 ms101 commented Jun 8, 2020 •
edited by phy25

Fixes #3157

Klap-in
Klap-in reviewed Jun 9, 2020
View reviewed changes
install.php Show resolved Hide resolved
@Klap-in
Copy link
Collaborator

Klap-in commented Jun 9, 2020 •
edited

Bcrypt is wide supported? It doesn’t need a requirements check for poor hosting or something like that?
Further fine for me.

@RVxLab
Copy link

RVxLab commented Jun 13, 2020

From what I gathered, bcrypt is implemented into PHP's core as of 5.3, see https://www.php.net/manual/en/function.crypt.php

phy25
phy25 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Collaborator

@phy25 phy25 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I missed this part in #2936...

@splitbrain splitbrain merged commit 46a290c into dokuwiki:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klap-in Klap-in Klap-in approved these changes

@phy25 phy25 phy25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install.php uses smd5 for hashing the admin's password
5 participants
@ms101 @Klap-in @RVxLab @phy25 @splitbrain