New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
central logging mechanism #3230
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a logger mechanism and a new data/log directory. This is a first proof of concept. It's built on top of the new global error handling mechanism Things to discuss: * should we adopt PSR-3 somehow? if yes, how and should plugins be able to drop-in other psr3 loggers? * how to configure which facilities shall be logged? * should we implement a log deletion feature? * is the log format sensible? * should we implement a log viewer admin plugin? * should logging trigger events (it should maybe replace the deprecation event)
This allows for easy viewing of the available logs. The log format was sligthly adjusted again for easier parsing.
Log facitlities can now be disabled. By default only debug is disabled. It might make sense to by default disable deprecated as well? Debug logging is now independend of the allowdebug method. allowdebug was often used in two ways: for displaying errors directly to the user and for logging to the debug log. Now it only controls the former.
I worked some more on this. Let's summarize:
Things I'm unsure about:
Feedback welcome |
merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a logger mechanism and a new data/log directory. This is a first proof of concept. It's built on top of the new global error handling mechanism of #3203
Things to discuss:
how to configure which facilities shall be logged?should we implement a log viewer admin plugin?