HTTPClient: Fix missing processing of redirections with status code 303, 307, 308. #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…03, 307, 308. HTTP/1.1 (RFC 7231) and RFC 7538 also define the redirection status codes 303, 307 and 308. These should be also supported as they are used more widely nowadays (e.g. Google Docs).
|
I guess it is practical to keep the unit tests up to date with these changes. |
|
The problem is that httpbin is neglected and redirect tests have been disabled for a long time now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/1.1 (RFC 7231) and RFC 7538 also define the redirection status codes 303, 307 and 308. These should be also supported as they are used more widely nowadays (e.g. Google Docs).