Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake aggregation pushdown support #620

Merged
merged 12 commits into from
Jan 27, 2022
Merged

Snowflake aggregation pushdown support #620

merged 12 commits into from
Jan 27, 2022

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Jan 26, 2022

  • Bump Multicorn to version where SQLAchemy backed FDWs can also push down upper relations
  • Add end-to-end tests for the above, by utilizing the existing pgorigin container, seeding it with some data and mounting it explicitly using multicorn.sqlalchemyfdw.SqlAlchemyFdw

CU-23kfzuz

@gruuya gruuya requested a review from mildbyte January 26, 2022 14:01
@gruuya gruuya self-assigned this Jan 26, 2022
mildbyte
mildbyte reviewed Jan 27, 2022
View reviewed changes
pytestdebug.log Outdated Show resolved Hide resolved
test/splitgraph/conftest.py Outdated Show resolved Hide resolved
test/splitgraph/commands/test_mounting.py Show resolved Hide resolved
mildbyte
mildbyte approved these changes Jan 27, 2022
View reviewed changes
test/splitgraph/commands/test_multicorn_fdws.py
elif data_source == "pg":
assert _extract_pg_queries_from_explain(result)[0] == (
'SELECT avg(public.account.balance) AS "avg.balance", count(*) AS "count.*" '
"FROM public.account WHERE public.account.firstname LIKE 'Su_an%%'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original query has WHERE firstname ~~ 'Su_an%' whereas this one has WHERE public.account.firstname LIKE 'Su_an%%' -- shouldn't it also only have one percentage sign?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, the answer is no, and the reason is documeted here: https://docs.sqlalchemy.org/en/14/faq/sqlexpressions.html#why-are-percent-signs-being-doubled-up-when-stringifying-sql-statements

@gruuya gruuya merged commit 1e7513e into master Jan 27, 2022
@gruuya gruuya deleted the snowflake-agg-pushdown-support-cu-23kfzuz branch January 27, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mildbyte mildbyte mildbyte approved these changes

Assignees

@gruuya gruuya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gruuya @mildbyte