Amazon Athena data source #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gruuya
commented
Feb 17, 2022
gruuya
commented
- Add another S3-focused data source, this time backed by Amazon Athena, internally employing our SQLAlchemy FDW
- Install missing libs in the engine Dockerfile (PyAthena, pandas)
- Fix CSV mount example, and make Snowflake plugin default to batch size of 10000 if none specified
mildbyte
approved these changes
Feb 17, 2022
| build_commandline_help(credentials_schema) + "\n" + build_commandline_help(params_schema) | ||
| ) | ||
|
|
||
| _icon_file = "snowflake.svg" |
There was a problem hiding this comment.
Use something like https://symbols.getvecta.com/stencil_5/0_aws-athena.bb0d0ced14.svg?
splitgraph/ingestion/csv/__init__.py
Outdated
| "s3_secret_key": "abcd", | ||
| "connection": | ||
| { | ||
| "connection_type": "s3", |
| "aws_access_key_id": {"type": "string", "title": "AWS Access Key Id"}, | ||
| "aws_secret_access_key": {"type": "string", "title": "AWS Secret Access Key"}, | ||
| }, | ||
| } |
There was a problem hiding this comment.
These should be required, e.g.:
Suggested change
| } | |
| "required": ["aws_access_key_id", "aws_secret_access_key"], | |
| } |
Comment on lines
119
to
120
| aws_access_key_id = self.params["aws_access_key_id"] | ||
| aws_secret_access_key = self.params["aws_secret_access_key"] |
There was a problem hiding this comment.
I think this comes from credentials (not merged into params)
Suggested change
| aws_access_key_id = self.params["aws_access_key_id"] | |
| aws_secret_access_key = self.params["aws_secret_access_key"] | |
| aws_access_key_id = self.credentials["aws_access_key_id"] | |
| aws_secret_access_key = self.credentials["aws_secret_access_key"] |
There was a problem hiding this comment.
Curiously, it actually works properly either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.