Improved support for Windows systems #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ironment variable set
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the helper class
class RESTAPIClientin some of my Python code. It worked fine for me, but failed on some of my colleagues which have Windows machines. Even though they had runsgr cloud addandsgr cloud loginand their~/.splitgraph/.sgconfigfiles looked fine, splitgraph code complained that it couldn't find any configuration for the remote.While digging into this I discovered that the .sgconfig file is only loaded if the environment variable HOME is set, since it looks in
os.environ["HOME"]. Adding the environment variable to my collegues' systems fixed the problem. However, this environment variable is not standard on Windows systems.A better, cross-platform, way of finding the user's home directory is
os.path.expanduser(~).There is one more instance of
os.environ["HOME"]in the codebase but it's in the code for the engine, which I presume always runs on a Unix system anyway.