Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative for AlwaysReturnControlSplitClient in v4.4.4 #383

Closed
sundarsan opened this issue Mar 28, 2023 · 4 comments
Closed

Alternative for AlwaysReturnControlSplitClient in v4.4.4 #383

sundarsan opened this issue Mar 28, 2023 · 4 comments

Comments

@sundarsan
Copy link

sundarsan commented Mar 28, 2023

I have upgraded the io.split.client:java-client to v4.4.4 and I am facing this import issue (AlwaysReturnControlSplitClient) what's the alternative for the same

Screenshot 2023-03-28 at 7 56 58 AM

Note: i could not get much with google searches and documentation, but what i got to know is this has been removed in one of the PR

I also tried alternatives based on the below PR link and i could not succeed as well

#278

@hbqdev
Copy link

hbqdev commented Mar 28, 2023

Hi @sundarsan
Can you please share with us the error you saw when you tried the workaround in PR #278 ?

As mentioned, we have removed that class and it should not be used in general for our public API. There is no 1:1 replacement and unfortunately we don't have any alternatives besides what is already mentioned.

Regards,

@sundarsan
Copy link
Author

sundarsan commented Mar 29, 2023

Screenshot 2023-03-29 at 3 40 56 PM

I have two problem here

  1. I need to return SplitClient Instance in our mock method
  2. even with your suggestion, i donot see import package for SplitClientForTest class in v4.4.4 version which we are using

@hbqdev
Copy link

hbqdev commented Mar 29, 2023

Hi @sundarsan

1- SplitClientForTest implements SplitClient so returning an instance of SplitClientForTest would solve this point.

2- SplitClientForTest belongs to java-client-testing so, in order to be able to import it, you need to add this dependency to his pom.xml

Please give that a try and let us know.

Regards,

@hbqdev
Copy link

hbqdev commented Apr 6, 2023

Hi @sundarsan
I'm closing out this issue, you can open a new issue if you still have problems.

Regards,

@hbqdev hbqdev closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants