Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new audio changes to XJS #332

Closed
nelson-temporal opened this issue Apr 3, 2021 · 2 comments
Closed

Apply new audio changes to XJS #332

nelson-temporal opened this issue Apr 3, 2021 · 2 comments
Assignees
@nelson-temporal
Labels
enhancement review
Milestone
2.11.0

Comments

@nelson-temporal
Copy link
Collaborator

Need to make changes to audio functionality of xjs to be able to adapt to XBC's new audio engine.
For now, I think we need to make this as seamless as possible such that no new codes will be needed for the implementing script, i.e. the framework itself will be checking for usage of new audio engine and use microphonedev2 or audiodev accordingly.
@nelson-temporal nelson-temporal added this to the 2.11.0 milestone Apr 3, 2021
@nelson-temporal
Copy link
Collaborator Author

For code review/test

SML-MeSo added a commit that referenced this issue Apr 15, 2021
@SML-MeSo
feat: Apply new audio changes to XJS
28e6da8 
- fix: filter via return for audio engine check and not function existence itself
- fix: getting primary mic/speaker when in new audio engine returns wrong device ID

closes #332
@SML-MeSo SML-MeSo assigned nelson-temporal and unassigned SML-MeSo Apr 15, 2021
@nelson-temporal
Copy link
Collaborator Author

Validated.
Merged to 2.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelson-temporal nelson-temporal

Labels
enhancement review
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@SML-MeSo @nelson-temporal