Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$albumRequestVar don't work for child albums when cached #263

Open
suetti opened this issue Apr 23, 2013 · 0 comments
Open

$albumRequestVar don't work for child albums when cached #263

suetti opened this issue Apr 23, 2013 · 0 comments

Comments

@suetti
Copy link

suetti commented Apr 23, 2013

galalbum.class.php line 298

The cachekey don't consider the $parent, so the cachekey always contains parent = 0;

One suggestion for a solution:

    /* implement tree-style albums*/
    if ($modx->getOption('checkForRequestAlbumVar',$scriptProperties,false)) {
        $albumRequestVar = $modx->getOption('albumRequestVar',$scriptProperties,'galAlbum');
        if (!empty($_REQUEST[$albumRequestVar])){
            $parent = $_REQUEST[$albumRequestVar];
            $scriptProperties['parent'] = $parent;
        };                            
    }

    $cacheKey = 'gallery/album/list/'.md5(serialize($scriptProperties));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant