feat(code): add custom validators for account configs #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hetangmodi-crest
added
enhancement
artemrys
requested changes
Mar 26, 2024
|
Updated the docs and smoke tests as well. |
artemrys
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
LGTM, just one question - did you try it on some particular add-on? Let's say Cisco Meraki one.
@kkedziak-splunk can you please take a look as well?
|
I tried and tested the change on the one of the recent add-ons that I worked upon. |
kkedziak-splunk
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Feature request: allow custom code for the REST handlers #520 issue.