Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(configuration): display UCC version #1221

Merged
merged 14 commits into from
Jun 5, 2024
Merged

feat(configuration): display UCC version #1221

merged 14 commits into from
Jun 5, 2024

Conversation

vtsvetkov-splunk
Copy link
Collaborator

@vtsvetkov-splunk vtsvetkov-splunk commented Jun 3, 2024 •
edited
Loading

Issue number: ADDON-71111

Summary

Changes

  • added a label on Configuration page to show UCC version
  • added props in meta of globalConfig.json to opt out of this label
  • A browser console shows a message from us with a hope devs look at it

User experience

User would observe the label "Made with UCC v" near OpenAPI.json button on the configuration page

small screen

image (this one bugs me, but I want to reorganize the layout in separate task)

normal screen

image

on hover state

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@vtsvetkov-splunk vtsvetkov-splunk marked this pull request as ready for review June 4, 2024 10:13
@vtsvetkov-splunk vtsvetkov-splunk requested review from a team as code owners June 4, 2024 10:13
artemrys
artemrys reviewed Jun 4, 2024
View reviewed changes
tests/ui/test_configuration_page.py Outdated Show resolved Hide resolved
splunk_add_on_ucc_framework/schema/schema.json Outdated Show resolved Hide resolved
vtsvetkov-splunk and others added 3 commits June 5, 2024 11:08
@vtsvetkov-splunk
extend tests and fix schema.json
91334b5
@vtsvetkov-splunk
Merge remote-tracking branch 'refs/remotes/origin/develop' into featu…
5cbabb1 
…re/ucc-version-on-ui

# Conflicts:
#	ui/src/pages/Configuration/stories/__images__/ConfigurationPage-configuration-page-view-chromium.png
#	ui/src/pages/stories/__images__/GlobalConfigPlayground-global-config-playground-chromium.png
@srv-rr-github-token
update screenshots
d4ccd8f
soleksy-splunk
soleksy-splunk previously approved these changes Jun 5, 2024
View reviewed changes
@vtsvetkov-splunk
Copy link
Collaborator Author

I just wanted to add a simple test for Configuration page and I had to fix a lot of underlying components to make it work...

soleksy-splunk
soleksy-splunk approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

artemrys
artemrys approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemrys artemrys merged commit a63d8b3 into develop Jun 5, 2024
60 of 61 checks passed
@artemrys artemrys deleted the feature/ucc-version-on-ui branch June 5, 2024 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hetangmodi-crest hetangmodi-crest hetangmodi-crest left review comments

@artemrys artemrys artemrys approved these changes

@soleksy-splunk soleksy-splunk soleksy-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vtsvetkov-splunk @artemrys @hetangmodi-crest @soleksy-splunk @srv-rr-github-token