Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(code): update file, dir checks condition #624

Merged
merged 2 commits into from
Feb 1, 2023
Merged

chore(code): update file, dir checks condition #624

merged 2 commits into from
Feb 1, 2023

Conversation

hetangmodi-crest
Copy link
Contributor

Updating the file or directory checks using isfile and isdir of the os.path module.

@hetangmodi-crest hetangmodi-crest added the python Pull requests that update Python code label Feb 1, 2023
@hetangmodi-crest hetangmodi-crest self-assigned this Feb 1, 2023
artemrys
artemrys requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hetangmodi-crest Please fix the unit tests, they depend on mocking os.path.exists function which you replaced.

@hetangmodi-crest
Copy link
Contributor Author

Fixed the unit test cases.

@artemrys artemrys changed the base branch from main to release/v5.20.0 February 1, 2023 13:22
@artemrys artemrys merged commit d4685f2 into release/v5.20.0 Feb 1, 2023
@artemrys artemrys deleted the chore/update-file-check-conditions branch February 1, 2023 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys requested changes

Assignees

@hetangmodi-crest hetangmodi-crest

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hetangmodi-crest @artemrys