feat: Scripted input support requirement test #442
Conversation
nandinivij
force-pushed
the
req_test/scripted_input
branch
from
c08af82
to
ed3ee93
Compare
|
Expected release notes (by @nandinivij) features: others (will not be included in Semantic-Release notes):
|
| @@ -162,6 +162,25 @@ def get_events(self): | |||
| LOGGER.info( | |||
| f"sending data transport_type:forwarder/uf_file_monitor filename:{filename} " | |||
| ) | |||
| elif transport_type in ( | |||
| "scripted_input", | |||
| "scripted input", | |||
There was a problem hiding this comment.
Why do we have "scripted input" and "scripted_input"?
How are transport type values decided?
There was a problem hiding this comment.
In requirement files we specify transport types- there are these two common variations in existing logs.
Transport type values are added by the dev team to requirement logs based on the ingestion type of the log in the addon
There was a problem hiding this comment.
Should we accept only 1 one of them?
Not to create options where we do not need to.
There was a problem hiding this comment.
we will document only 1 version so that we don't use others in the future, but we are allowing multiple versions to avoid going back and changing existing log files. It is the case with modinput too
There was a problem hiding this comment.
@nandinivij Can we ensure we document official usage for input types which is sync with PSA input types?
There was a problem hiding this comment.
Also just for a record are there too many addons which use variations if not we can have them to use same version and ensure consistency and remove unwanted support from here? Do we have a list?
There was a problem hiding this comment.
@bhargav-nariyani-crest I understand the concern, but this is beyond the scope of this PR. The logs exist before we supported them to work with the requirement test. These are lexical variations and this is to facilitate requirement test work without changing existing logs.
This does not change the transport type we are using in PSA it is the defined transport type in the requirement log.
Created a Jira to eliminate various variations in transport type from TA'sADDON-44372
There was a problem hiding this comment.
Thanks @nandinivij .
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Please review following changes -