Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove splunk-appinspect dependency #464

Merged
19 commits merged into from
Dec 16, 2021
Merged

feat: remove splunk-appinspect dependency #464

19 commits merged into from
Dec 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 26, 2021

This PR uses addonfactory_splunk_conf_parser_lib instead of splunk_appinspect for all .conf files parsers.

@ghost ghost marked this pull request as ready for review November 26, 2021 14:31
@ghost ghost requested a review from edersonbrilhante as a code owner November 26, 2021 14:31
@ghost ghost requested a review from ricardom-splunk November 26, 2021 14:32
ghost pushed a commit to splunk/addonfactory-splunk-conf-parser-lib that referenced this pull request Dec 1, 2021
@artemrys
fix: item_dict returns empty stanzas
3f10cea 
This fix is a result of migrating from splunk-appinspect to this library in pytest-splunk-addon.

Reference PR: splunk/pytest-splunk-addon#464

Closes #36.
@ghost ghost mentioned this pull request Dec 1, 2021
Merged
ghost pushed a commit to splunk/addonfactory-splunk-conf-parser-lib that referenced this pull request Dec 1, 2021
@artemrys
fix: item_dict returns empty stanzas
c351f1e 
This fix is a result of migrating from splunk-appinspect to this library in pytest-splunk-addon.

Reference PR: splunk/pytest-splunk-addon#464

Closes #36.
ghost pushed a commit to splunk/addonfactory-splunk-conf-parser-lib that referenced this pull request Dec 1, 2021
@artemrys
fix: item_dict returns empty stanzas
d0f2c34 
This fix is a result of migrating from splunk-appinspect to this library in pytest-splunk-addon.

Reference PR: splunk/pytest-splunk-addon#464

Closes #36.
@ghost ghost mentioned this pull request Dec 1, 2021
Closed
hsekowski-splunk
hsekowski-splunk previously approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@hsekowski-splunk hsekowski-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arys-splunk ,
Beside comment regarding gt , let me pay your attention to snyk that's failing (because of lack of some dependencies)

@ghost ghost requested review from ricardom-splunk and removed request for ricardom-splunk December 9, 2021 14:24
@ghost
Copy link
Author

ghost commented Dec 10, 2021 •
edited by ghost

cim_field_parser needs to be changed to respect new parsers.

pytest-splunk-addon/pytest_splunk_addon/tools/cim_field_report.py

Line 501 in 10f0e49

eventtype: None for eventtype in parser.eventtype_parser.eventtypes.sects

UPD: done in 9160fe1

@ghost ghost force-pushed the refactor/conf-parser branch 2 times, most recently from 1c121b9 to 9160fe1 Compare December 14, 2021 22:25
@ghost ghost changed the base branch from main to develop December 15, 2021 00:31
@ghost ghost mentioned this pull request Dec 15, 2021
Closed
Artem Rys and others added 10 commits December 15, 2021 11:19
ci: apply concurrency for build-test-release job
d6e8a89 
Inspired by pypa/pip@fa2d428

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
@artemrys
refactor: use conf-parser in EventtypeParser instead of splunk-appins…
f3701ae 
…pect
@artemrys
refactor: use conf-parser in SavedsearchesParser instead of splunk-ap…
6cbc550 
…pinspect
@artemrys
refactor: use conf-parser in TransformsParser instead of splunk-appin…
da8db9c 
…spect
@artemrys
refactor: cache parsed results
b585df0
@artemrys
refactor: use conf-parser in PropsParser instead of splunk-appinspect
345ac95
@artemrys
refactor: remove splunk-appinspect from AddonParser
0c5c25b
@artemrys
docs: remove splunk-appinspect mentions from PropsParser
4b3e4dc
@artemrys
test: empty stanza in savedsearches.conf
ba71246
@artemrys
refactor: use new EventtypeParser in cim_field_report
400e62c
@ghost ghost force-pushed the refactor/conf-parser branch from 8ef00c9 to 2f149b7 Compare December 15, 2021 10:31
@github-actions
Copy link
Contributor

Expected release notes (by @arys-splunk)

features:
remove splunk_appinspect dependency (c2df52c)

others (will not be included in Semantic-Release notes):
add debug-statements to pre-commit configuration (0f7a326)
move some public methods to be private (260b0f6)
not run tests with Splunk 8.0 (2f149b7)
restructure tests (9a640c5)
style the docs pagee (8e7b8e3)
rename to pytest_splunk_addon_data (f4403bf)
remove create_new_eventgen (fa19546)
use conf-parser in eventgen.conf parser (6abd3b5)
use new EventtypeParser in cim_field_report (400e62c)
empty stanza in savedsearches.conf (ba71246)
remove splunk-appinspect mentions from PropsParser (4b3e4dc)
remove splunk-appinspect from AddonParser (0c5c25b)
use conf-parser in PropsParser instead of splunk-appinspect (345ac95)
cache parsed results (b585df0)
use conf-parser in TransformsParser instead of splunk-appinspect (da8db9c)
use conf-parser in SavedsearchesParser instead of splunk-appinspect (6cbc550)
use conf-parser in EventtypeParser instead of splunk-appinspect (f3701ae)
apply concurrency for build-test-release job (d6e8a89)
remove .idea folder (18c73e6)
bump lxml from 4.6.4 to 4.6.5 (4ad4467)
bump deps/build/addonfactory_test_matrix_splunk (ac18542)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ghost ghost changed the title refactor: use conf-parser instead of splunk-appinspect feat: remove splunk-appinspect dependency Dec 15, 2021
@ghost ghost mentioned this pull request Dec 16, 2021
Closed
@ghost ghost requested a review from hsekowski-splunk December 16, 2021 13:16
@ghost ghost merged commit 206c7d1 into develop Dec 16, 2021
@ghost ghost deleted the refactor/conf-parser branch December 16, 2021 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.12.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.12.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edersonbrilhante edersonbrilhante Awaiting requested review from edersonbrilhante

@okashaev-splunk okashaev-splunk Awaiting requested review from okashaev-splunk

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanfaircloth @hsekowski-splunk @ricardom-splunk @artemrys