Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove splunk-appinspect dependency #499

Merged
6 commits merged into from
Feb 18, 2022
Merged

feat: remove splunk-appinspect dependency #499

6 commits merged into from
Feb 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2021 •
edited by ghost

For more details, please check out #475.

Closes #475.

Artem Rys and others added 4 commits December 28, 2021 15:50
@artemrys
feat: remove splunk-appinspect dependency (#464)
bfde00f 
BREAKING CHANGE: eventgen.conf is not supported anymore, please migrate to pytest-splunk-addon-data.conf

* refactor: use conf-parser in EventtypeParser instead of splunk-appinspect
* refactor: use conf-parser in SavedsearchesParser instead of splunk-appinspect
* refactor: use conf-parser in TransformsParser instead of splunk-appinspect
* refactor: use conf-parser in PropsParser instead of splunk-appinspect
* refactor: remove splunk-appinspect from AddonParser
* docs: remove splunk-appinspect mentions from PropsParser
* test: empty stanza in savedsearches.conf
* refactor: use new EventtypeParser in cim_field_report
* refactor: use conf-parser in eventgen.conf parser
* chore: remove create_new_eventgen
* feat: remove splunk_appinspect dependency
* chore: rename to pytest_splunk_addon_data
* chore: style the docs pagee
* ci: restructure tests
* ci: not run tests with Splunk 8.0
* refactor: move some public methods to be private
* ci: add debug-statements to pre-commit configuration
@artemrys
docs: remove release_history page
8f47f04
@artemrys
ci: upload coverage to codecov
7278267
@artemrys
chore: remove all eventgen signs
3cf2f3b
@ghost ghost mentioned this pull request Dec 28, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@e947cb2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage        ?   94.52%           
=======================================
  Files           ?       50           
  Lines           ?     2629           
  Branches        ?        0           
=======================================
  Hits            ?     2485           
  Misses          ?      144           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e947cb2...fa36211. Read the comment docs.

@ghost ghost marked this pull request as ready for review December 29, 2021 15:09
@uoboda-splunk
Copy link
Contributor

Was it tested with some KO tests runs for TAs?

@ghost
Copy link
Author

ghost commented Feb 9, 2022

Was it tested with some KO tests runs for TAs?

Yep, but I'll probably rebase this PR today and check one more time after latest changes.

@uoboda-splunk
Copy link
Contributor

Was it tested with some KO tests runs for TAs?

Yep, but I'll probably rebase this PR today and check one more time after latest changes.

We can do a test run with addonfactory-repository-template for all addons

@github-actions
Copy link
Contributor

Expected release notes (by @arys-splunk)

features:
remove splunk-appinspect dependency (#464) (bfde00f)

others (will not be included in Semantic-Release notes):
merge with main (1009852)
remove matrix option from test-splunk-matrix step (#545) (5464510)
merge with main (fa36211)
remove all eventgen signs (3cf2f3b)
upload coverage to codecov (7278267)
remove release_history page (8f47f04)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@uoboda-splunk
Copy link
Contributor

please merge to develop

uoboda-splunk
uoboda-splunk previously approved these changes Feb 18, 2022
View reviewed changes
@ghost ghost changed the base branch from main to develop February 18, 2022 11:57
@ghost ghost dismissed uoboda-splunk’s stale review February 18, 2022 11:57

The base branch was changed.

@ghost ghost merged commit a56e9d1 into develop Feb 18, 2022
@ghost ghost deleted the feat/remove-splunk-appinspect branch February 18, 2022 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssamaddar-crest ssamaddar-crest Awaiting requested review from ssamaddar-crest

@kpanchal-crest kpanchal-crest Awaiting requested review from kpanchal-crest

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for eventgen.conf
6 participants
@codecov-commenter @uoboda-splunk @srv-rr-github-token @hsekowski-splunk @ricardom-splunk @artemrys